Skip to content

Conversation

@biru-codeastromer
Copy link
Contributor

@biru-codeastromer biru-codeastromer commented Feb 13, 2025

Fixes jenkins-infra/jenkins.io#7126

Description :

Reference :

@kmartens27
Copy link
Contributor

This PR will need to be merged at the same time as jenkins-infra/jenkins.io#7841

@biru-codeastromer
Copy link
Contributor Author

Got it .

@zbynek
Copy link
Contributor

zbynek commented Feb 14, 2025

Each project that uses these templates can set value of the githubBranch property separately. Unless I miss something, this PR is not needed for jenkins-infra/jenkins.io#7126 . Instead githubBranch should be changed in jenkins.io here: https://github.com/jenkins-infra/jenkins.io/blob/80ad271280e1705b442b15662570e1b0441f3040/content/_layouts/frame.html.haml#L115 and that's already done in jenkins-infra/jenkins.io#7841.

(AFAIK all projects other than jenkins.io already use main as default branch, so this can be safely merged after jenkins-infra/jenkins.io#7841).

@biru-codeastromer
Copy link
Contributor Author

Thank you for the clarification! I see your point regarding the githubBranch property being customizable per project. Since the necessary changes for jenkins.io have already been handled in jenkins-infra/jenkins.io#7841, and most other projects already default to main, it makes sense that this PR is not strictly required for jenkins-infra/jenkins.io#7126.

I’ll wait for jenkins-infra/jenkins.io#7841 to be merged first, and if this PR still serves any additional purpose afterward, I can revisit it. If it’s deemed unnecessary, I’m happy to close it as resolved.

Let me know if you’d like me to adjust anything here or proceed differently. Thanks for reviewing and providing clarity!

@krisstern krisstern closed this Feb 20, 2025
@krisstern krisstern reopened this Feb 20, 2025
@krisstern
Copy link
Member

This PR will need to be merged at the same time as jenkins-infra/jenkins.io#7841

Noted, please notifiy when I will need to merge this pull request so I can better plan and coordinate with the team

@biru-codeastromer biru-codeastromer changed the title chore: replace master references with main of jenkins.io website chore: replace "master" references with "main" of jenkins.io website Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use main as primary branch

4 participants